Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assigning playWhenReady wrongly in codelab-00 #73

Open
masoomyf opened this issue Nov 14, 2021 · 0 comments
Open

Assigning playWhenReady wrongly in codelab-00 #73

masoomyf opened this issue Nov 14, 2021 · 0 comments

Comments

@masoomyf
Copy link

In PlayerActivity.releasePlayer(), inside player?.run block playWhenReady is assigning wrong:

         // Inside run block 'this' refer to player and current context is also player
         // so we can use:
         // [email protected] = playWhenReady
         // instead of below line.
         **playWhenReady = this.playWhenReady**
@masoomyf masoomyf changed the title Assigning playWhenReady wrongly in codelab-001 Assigning playWhenReady wrongly in codelab-00 Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@masoomyf