Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: store block timestamps #189

Closed
joel-u410 opened this issue Dec 9, 2024 · 3 comments
Closed

enhancement: store block timestamps #189

joel-u410 opened this issue Dec 9, 2024 · 3 comments

Comments

@joel-u410
Copy link
Contributor

joel-u410 commented Dec 9, 2024

It'll be good to store timestamp for blocks along with height so that transactions and balances can be queried with timestamps.

I propose introducing a blocks table to capture that data. (Will submit a PR for this soon)

At this point, since mainnet has now launched, I assume we should introduce new migrations rather than modifying existing ones, correct? (cc @mateuszjasiuk @Fraccaman)

@Fraccaman
Copy link
Member

Fraccaman commented Dec 9, 2024

Yeah, this is something @mateuszjasiuk is working on! Yeah now we need to introduce new migrations :)

@joel-u410
Copy link
Contributor Author

Yeah, this is something @mateuszjasiuk is working on! Yeah now we need to introduce new migrations :)

Ah .. I just wrote it myself and opened a PR here: #190 :)

@mateuszjasiuk
Copy link
Collaborator

That's fine! I should've added issue. Anyways, I think as a rule of thumb maybe we should add a label like: "ready" or sth, to indicate that issue makes sense and we do not double the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants