Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namadillo: Claim & Stake proposed changes #1419

Open
jurevans opened this issue Dec 18, 2024 · 0 comments
Open

Namadillo: Claim & Stake proposed changes #1419

jurevans opened this issue Dec 18, 2024 · 0 comments

Comments

@jurevans
Copy link
Collaborator

jurevans commented Dec 18, 2024

Currently, in the Claim & Claim+Stake flows, there's no way to specify which rewards you wish to claim/stake. This presents a problem if, for example, the user is signing with a Ledger HW Wallet, as these cannot be batched, meaning the user must sequentially sign x number of transactions on the device, which could take a long time. Also, there may be rewards that the user doesn't want to claim, because they may not be high enough to justify the gas costs.

A proposed solution is to give the user the option to choose which rewards they want to claim or claim & stake. This will need some design input from @ChrisHoltDesign. Perhaps this could be an option that defaults to "Claim all", with the option of filtering any rewards they do not wish to claim.

Also, it was noted that we currently accept these transactions in a random order, which is not ideal for reviewing on the Ledger. We should better control which order these will be signed in, perhaps sorting by amount, so long as it's consistent.

@jurevans jurevans added feature App: Namadillo Ledger HW Wallet Ledger HW Wallet integration labels Dec 18, 2024
@jurevans jurevans added this to the Namadillo Mainnet Readiness milestone Dec 18, 2024
@anoma anoma deleted a comment from berryMo27 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant