feat: add time title helper #1432
Open
+58
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurevans
reviewed
Dec 20, 2024
apps/namadillo/src/utils/dates.ts
Outdated
| endTimeInSeconds: bigint | ||
| ): string | undefined => { | ||
| // TODO is this useful? | ||
| return; |
There was a problem hiding this comment.
I would say this isn't useful, maybe we should delete any references to this function sometime soon - it's been immediately returning for many months now :D
There was a problem hiding this comment.
Yeah, I was thinking the same!
But I explored the feature and Figma and realized this is related to the remaining time for the ongoing proposal. So it was an one line change and I did it already 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
titleto proposal times so user can check the timezoneAlso, fix the table name that was saying
UTCwhile it was a localized value. Now it render the timezone as wellcloses #1426
Some sample simulating different cities: