-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop namadan if --path checksum does not match --hash #4108
Comments
if the hash doesn't match the migration file the node will crash with:
so the issue is somewhere else |
The crash because of the hash mismatch implies a restart, and restarts currently cause a panic because the state cannot be restored: #4112 . |
can we close this? |
@sug0 @tzemanovic @grarco your choice if we can close |
@tzemanovic confirmed that we halt on an invalid hash as soon as we boot up. the only explanation for the hash check to have succeeded is if the user provided a checksum they computed themselves over the faulty file. |
Several validators failed to upgrade from v0.45.1 to v0.46, because they supplied a HTML file (wget github page) instead of JSON file.
After running
namadan-0.46.0 ledger run --height 182000 --path $MIGRATION_JSON --hash acadd7d124804448b3c7f7b3dc0c3bc536fe6dbd1594757d5a992d47ecacc5c6
their nodes came in an inconsistent state and they need to sync from scratch. This could perhaps be prevented by having namadan verify the $MIGRATION_JSON.The text was updated successfully, but these errors were encountered: