Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration tendermint_mode=Full has unexpected behavior may lead to double sign #4139

Open
0x4r45h opened this issue Dec 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@0x4r45h
Copy link
Contributor

0x4r45h commented Dec 3, 2024

Description:

Namada V1.0.0

I need clarification on the tendermint_mode configuration in config.toml. Specifically, the behavior when setting it to "Full".

Steps to Reproduce:

Start a node in Full mode (tendermint_mode = "Full").
Observe the "This node is not validator" message at startup.
If the node has the correct consensus keys in the cometbft directory and enough voting power (VP), it starts signing blocks regardless of the mode.

Observed Behavior:

When set to Validator, if the validator keys are missing from wallet.toml, the node crashes with an error.
When set to Full, the node runs without issue but may start signing if it has consensus keys and enough VP.

Expected Behavior:

Clear and predictable behavior depending on the mode to prevent potential double signing or misconfiguration.

Questions:

1.Are there any additional side effects of this configuration?
2. What this mode should be in multi-signer setups?
For instance, should full nodes connected to a cosigner cluster be set to "Validator" or "Full"?
Setting to "Validator" requires keys in wallet.toml (which could be any validator key, not the actual one used in the multi-signer), while "Full" works without them. Are there any risks or hidden side effects in doing this?

Expected Impact:

Clarifying this behavior is critical for avoiding misconfigurations, especially in high-risk setups like multi-signing where improper modes could lead to double signing or node crashes.
I suggest removing this configuration entirely, if possible, similar to how other CometBFT-based chains operate. To my knowledge, these chains do not use this setting—the node simply begins signing blocks as long as it has sufficient voting power (VP).

@0x4r45h 0x4r45h added the bug Something isn't working label Dec 3, 2024
@brentstone
Copy link
Collaborator

@tzemanovic @Fraccaman @sug0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants