Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator-metadata/properties wonky #4202

Open
opsecx opened this issue Dec 23, 2024 · 7 comments
Open

Validator-metadata/properties wonky #4202

opsecx opened this issue Dec 23, 2024 · 7 comments
Labels
bug Something isn't working PoS

Comments

@opsecx
Copy link

opsecx commented Dec 23, 2024

Created a testnet (alpaca) validator with both commission-rate and max-commission-rate-change.

Later querying the validator metadata yields the following:

"Only one of the commission rate and max commission change per epoch was found for validator (redacted) in epoch 420. This is a bug and should be reported."

@opsecx opsecx added the bug Something isn't working label Dec 23, 2024
@opsecx opsecx changed the title Validator-metadata wonky Validator-metadata/properties wonky Dec 23, 2024
@opsecx
Copy link
Author

opsecx commented Dec 23, 2024

Not quite sure how this happened, ran a fairly standard init-validator command, for reference:

namadac init-validator --account-keys (redacted) --signing-keys (redacted, same as account-keys) --commission-rate (redacted) --max-commission-rate-change (redacted) --email (redacted)

no errors from cli and went straight through

@opsecx
Copy link
Author

opsecx commented Dec 23, 2024

Also not sure if this will keep the validator from functioning or cause issues on chain, will report on this. Would be interested to hear if anyone else is seeing this on Alpaca.

@brentstone
Copy link
Collaborator

Mind reaching out on discord to me to help debug? Curious to know your address. @brent

@opsecx
Copy link
Author

opsecx commented Dec 23, 2024

Validator looks to be in consensus set and working well. I wonder what will happen if I change commission-rate

@opsecx
Copy link
Author

opsecx commented Dec 23, 2024

It looks to respect the set max-commission-rate-change when running chance-commission-rate. (ie can't change rate beyond initially set limits). not sure why cli displays the error as above.

@opsecx
Copy link
Author

opsecx commented Dec 23, 2024

Update: As discussed with Brent, it displays fine now. Anyone else seeing this when querying newly created validators before becoming active?

@tzemanovic
Copy link
Member

hi, thanks for the report! I confirm the issue is that the commission-rate is set at pipeline epoch offset but it tries to read it from the current epoch

@tzemanovic tzemanovic added the PoS label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PoS
Projects
None yet
Development

No branches or pull requests

3 participants