Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated signatures in transactions #4203

Open
grarco opened this issue Dec 24, 2024 · 0 comments
Open

Duplicated signatures in transactions #4203

grarco opened this issue Dec 24, 2024 · 0 comments
Assignees

Comments

@grarco
Copy link
Collaborator

grarco commented Dec 24, 2024

Some of the transactions observed in mainnet are carrying duplicated inner signatures with the only difference in the two signature sections being the signer: in one of the two it is expressed as an address while in the other one as a public key. This behavior seems to happen on bundles containing a reveal_pk and a bond transaction.

When we construct the bundle we try to avoid duplicated SigningTxData structs to avoid this kind of situations but unfortunately it is still possible for two different instances of such type to lead to the same signature being produced. We should try to improve this check further or improve the logic that we use to discard duplicated sections

@grarco grarco self-assigned this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant