Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/ibc: ensure unique token IDs (backport #4154) #4178

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 11, 2024

Describe your changes

fixes a panic in strategy when a list of generated token IDs is not unique (as seen in https://github.com/anoma/namada/actions/runs/12213873245/job/34074078139)

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4154 done by [Mergify](https://mergify.com).

Copy link
Contributor Author

mergify bot commented Dec 11, 2024

Cherry-pick of 19c8bc3 has failed:

On branch mergify/bp/maint-libs-0.46/pr-4154
Your branch is up to date with 'origin/maint-libs-0.46'.

You are currently cherry-picking commit 19c8bc31a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both added:      .github/workflows/ci.yml
	both added:      Cargo.lock
	both added:      Cargo.toml
	both added:      crates/ibc/src/lib.rs
	both added:      wasm/Cargo.lock
	both added:      wasm_for_tests/Cargo.lock

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Dec 11, 2024
@tzemanovic tzemanovic force-pushed the mergify/bp/maint-libs-0.46/pr-4154 branch from c50a5c3 to 88815de Compare December 11, 2024 20:54
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Dec 11, 2024
@mergify mergify bot merged commit 5e657af into maint-libs-0.46 Dec 11, 2024
11 of 12 checks passed
@mergify mergify bot deleted the mergify/bp/maint-libs-0.46/pr-4154 branch December 11, 2024 20:56
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (396adf1) to head (88815de).
Report is 5 commits behind head on maint-libs-0.46.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           maint-libs-0.46    #4178      +/-   ##
===================================================
- Coverage            74.46%   74.46%   -0.01%     
===================================================
  Files                  341      341              
  Lines               107710   107710              
===================================================
- Hits                 80211    80209       -2     
- Misses               27499    27501       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant