Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with resource machine #251

Merged
merged 12 commits into from
Nov 24, 2023

rename nullifier key commitment to nullifier public key

ad23872
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Sync with resource machine #251

rename nullifier key commitment to nullifier public key
ad23872
Select commit
Loading
Failed to load commit list.
GitHub Actions / Clippy (beta) succeeded Nov 23, 2023 in 0s

Clippy (beta)

2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 2
Note 0
Help 0

Versions

  • rustc 1.75.0-beta.3 (b66b7951b 2023-11-20)
  • cargo 1.75.0-beta.3 (1d8b05cdd 2023-11-20)
  • clippy 0.1.75 (b66b795 2023-11-20)

Annotations

Check warning on line 150 in taiga_halo2/src/circuit/vp_circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of a fallible conversion when an infallible one could be used

warning: use of a fallible conversion when an infallible one could be used
   --> taiga_halo2/src/circuit/vp_circuit.rs:150:13
    |
150 |         val.try_into()
    |             ^^^^^^^^ help: use: `into`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
    = note: `-W clippy::unnecessary-fallible-conversions` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_fallible_conversions)]`

Check warning on line 150 in taiga_halo2/src/circuit/vp_circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

use of a fallible conversion when an infallible one could be used

warning: use of a fallible conversion when an infallible one could be used
   --> taiga_halo2/src/circuit/vp_circuit.rs:150:13
    |
150 |         val.try_into()
    |             ^^^^^^^^ help: use: `into`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
    = note: `-W clippy::unnecessary-fallible-conversions` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_fallible_conversions)]`