Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostname should also accept an encrypted vault value #1787

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

hostname should also accept an encrypted vault value #1787

wants to merge 3 commits into from

Conversation

nikiwaibel
Copy link

SUMMARY

i want to hide username, password and hostname in the inventory file.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • community.vmware.vmware_host_inventory
  • community.vmware.vmware_vm_inventory
ADDITIONAL INFORMATION
  • the patch is really simple, as it just replicates what is done with username and password (for hostname).
  • it also modifies the instructions section to reflect the change.

nikiwaibel added 3 commits July 2, 2023 00:04
@nikiwaibel
Update vmware_host_inventory.py: hostname should also accept an encry…
512db1a 
…pted vault value

like username and password, hostname should also accept an encrypted vault value
@nikiwaibel
Merge pull request #1 from nikiwaibel/nikiwaibel-patch-1
1979f39 
hostname should also accept an encrypted vault value
@nikiwaibel
Update vmware_vm_inventory.py
7cf1d0b 
hostname should accept an encrypted vault value
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9c00130cc4cd4993908fedb7542c1695

✔️ ansible-tox-linters SUCCESS in 8m 34s
✔️ build-ansible-collection SUCCESS in 9m 17s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 21m 51s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 20m 08s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 23m 12s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 50s

@mariolenz
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/052671e0714846d5aa1a2cb03db4382a

✔️ ansible-tox-linters SUCCESS in 8m 56s
✔️ build-ansible-collection SUCCESS in 9m 46s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 19m 17s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006239676 failed in 0s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006239677 failed in 0s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 51m 45s
✔️ ansible-galaxy-importer SUCCESS in 3m 45s

@ansibullbot
Copy link

@nikiwaibel this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. new_contributor Help guide this first time contributor labels Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_triage Needs a first human triage before being processed. new_contributor Help guide this first time contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikiwaibel @mariolenz @ansibullbot