Fixing issue on changing "disk_mode" #2096

[alezzandro]

SUMMARY

Fixing issue on changing "disk_mode" #2096.
As reported in the issue trying to change the disk_mode on an existing vm disk. If the disk is "independent_persistent" and I want to change it to "persistent" no change will be made. Other combinations also won't work.

I edited the vmware_guest_disk.py for including the disk_mode change in the VM reconfiguration if the disk_mode parameter is changing from the existing one.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

community.vmware.vmware_guest_disk

ADDITIONAL INFORMATION

Please note I've just made a small change that still requires you to pass to the module at least the following information:

- name: VMware Change Disk Mode
  hosts: localhost
  tasks:
  - name: Change disk mode for virtual machine using name
    community.vmware.vmware_guest_disk:
      hostname: "{{ vcenter_hostname }}"
      username: "{{ vcenter_username }}"
      password: "{{ vcenter_password }}"
      datacenter: "{{ vcenter_dc }}"
      name: "{{ vm_name }}"
      validate_certs: false
      disk:
        - controller_number: "{{ vm_disk_controller_number }}"
          unit_number: "{{ vm_disk_unit_number }}"
          disk_mode: "persistent" 
          size_kb: "{{ vm_disk_size_kb }}"
    delegate_to: localhost
    register: disk_facts

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/483bd4fbfdfc418690ef485734696cbf

❌ ansible-tox-linters FAILURE in 4m 40s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED