+extended format of plugin settings (now it can be set via arrays, li… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke at webpack.config.js. E.g.: ['fetchLocal', { source: 'locales', skip: true }])
*fixed sorting of final result - now it sorts correctly!
jaredleechn
reviewed
Nov 10, 2016
| @@ -4,7 +4,7 @@ import { join } from 'path'; | |||
|
|
|||
| function sortKey(obj) { | |||
| return Object.keys(obj) | |||
| .sort((a, b) => a.toString().toLowerCase() > b.toString().toLowerCase()) | |||
| .sort() | |||
There was a problem hiding this comment.
@plandem can you give a case for the updating of this line ?
There was a problem hiding this comment.
Sure! in your case you will not have same result. Sort can return: -1, 0, 1. Your way returning true/false only.
If you want to sort with case insensitive, then you must do like this:
sort = (a,b) => {
a = a.toLowerCase();
b = b.toLowerCase();
if( a == b) return 0;
if( a > b) return 1;
return -1;
};
or
sort = (a, b) => a.localeCompare(b, { sensitivity:'base' });
jaredleechn
reviewed
Nov 10, 2016
| ], | ||
| }, | ||
| }; | ||
|
|
There was a problem hiding this comment.
could you make a fix about the indent, using 2 spaces instead of tab? 😸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+extended format of plugin settings (now it can be set via arrays, like at webpack.config.js. E.g.: ['fetchLocal', { source: 'locales', skip: true }])
*fixed sorting of final result - now it sorts correctly!
+added cli arg to supress non critical information