Don't use the concrete implementation of web3.js in the getStakeActivation package
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know if this now means that we should move |
steveluscher
commented
Nov 18, 2024
| 'SysvarStakeHistory1111111111111111111111111' | ||
| ); | ||
| const SYSVAR_STAKE_HISTORY_ADDRESS = { | ||
| toBase58: () => 'SysvarStakeHistory1111111111111111111111111', |
There was a problem hiding this comment.
This works, because the only thing that parseAccountInfo() ever does with this thing is to call toBase58() on it.
‘Thin interfaces.’
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only place that
@solana/web3.jsis used in this shim – in a non-type position – is here. We can make a mock ofPublicKeyhere which breaks the last dependency on the actual implementation of@solana/web3.js. Now all that is used from that package are the types.