Always explicitly disable gzip
automatic decompression on reqwest client used by object_store
#6843
+49
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6842
Rationale for this change
Fixes an issue where enabling a non-default feature (
gzip
) forreqwest
would causeobject_store
to stop working if using the HTTP store against an HTTP server that supports gzip response compression.What changes are included in this PR?
Call the
no_gzip
method on the reqest ClientBuilder to ensure that even if thegzip
feature is enabled, theobject_store
client will not use the transparent decompression logic.I considered making this an option instead of always setting it, but since this is such a frustrating footgun to encounter and debug, I think its better to always set it unless there is a compelling reason not to.
Are there any user-facing changes?
My understanding is that most/all users interacting with object stores do not want the
gzip
compression logic (since none of the major cloud object store providers support it), so this change should not be breaking.