Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy comet-spark-shell #1013

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Oct 10, 2024

Which issue does this PR close?

N/A

Rationale for this change

This came up today because someone followed our documentation and found that the instructions did not work.

The bin/comet-spark-shell script is out of date (references wrong Comet version and options are not up to date) so it is probably best just to remove it and have users follow the installation instructions instead.

What changes are included in this PR?

Remove legacy script

How are these changes tested?

Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove andygrove merged commit 22613e9 into apache:main Oct 11, 2024
76 checks passed
@andygrove andygrove deleted the remove-legacy-bin branch October 11, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants