Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fallback to Spark if named_struct contains duplicate field names #1016

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Oct 12, 2024

Which issue does this PR close?

Closes #1015.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@viirya viirya force-pushed the fix_struct_duplicate_field_names branch from 59166c5 to c7b612d Compare October 12, 2024 16:29
@viirya viirya requested review from andygrove and huaxingao October 12, 2024 17:04
Copy link
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viirya viirya merged commit abd9f85 into apache:main Oct 13, 2024
74 checks passed
@viirya
Copy link
Member Author

viirya commented Oct 13, 2024

Thanks @huaxingao

@viirya viirya deleted the fix_struct_duplicate_field_names branch October 13, 2024 07:14
kazuyukitanimura pushed a commit to kazuyukitanimura/datafusion-comet that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comet named_struct fails on duplicate field names
2 participants