chore: Revert "chore: Reserve memory for native shuffle writer per partition (#988)" #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apache#988)" This reverts commit e146cfa.
viirya
changed the title
|
TPC-H ran clean for me on this PR. Thanks for the quick help! |
andygrove
approved these changes
Oct 15, 2024
viirya
added a commit
to viirya/arrow-datafusion-comet
that referenced
this pull request
Oct 16, 2024
…r per partition (apache#988)" (apache#1020)" This reverts commit 8d097d5.
andygrove
pushed a commit
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e146cfa.
Which issue does this PR close?
Closes #.
Rationale for this change
There is an issue #1019 caused by the patch. Reverting the patch temporarily to unblock other works.
What changes are included in this PR?
How are these changes tested?