build: Add build package workflow #1049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - name: Build Comet | ||
| run: make release PROFILES="${{ github.event.inputs.profiles }}" | ||
|
|
||
| - name: Upload Artifact |
There was a problem hiding this comment.
If this is for a quick way to start tests manually, wondering if we should upload?
There was a problem hiding this comment.
Upload is needed here, then we can download artifacts through summary:
https://github.com/wangyum/datafusion-comet/actions/runs/11649182523
There was a problem hiding this comment.
Got it. Are there cost implications associated with this? I would other reviewers for this point
At least do we need something like
retention-days: 1
overwrite: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
This PR adds build package workflow. Because some developers' development machines and running machines have different operating systems. After this PR, developers only need to choose the operating system they are running on the github action to build.
How are these changes tested?
Tested through github action:
https://github.com/wangyum/datafusion-comet/actions/runs/11649182523