minor: refactor UnaryExpr handling to make code more concise #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazuyukitanimura
approved these changes
Nov 8, 2024
viirya
approved these changes
Nov 8, 2024
|
Thanks @andygrove @kazuyukitanimura |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Following up from this comment in a recent PR, I wanted to explore the suggestion some more.
What changes are included in this PR?
Refactor
UnaryExprhandling inQueryPlanSerdeto make it more concise, but at the cost of increased complexity.I am looking for feedback if this is a good direction or not (I do not have a strong opinion either way). If we do like this approach then I can follow up to apply this to
BinaryExprandMathExpras well.How are these changes tested?
Existing tests