Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[substrait] make dependency on parquet optional #13593

Open
notfilippo opened this issue Nov 28, 2024 · 1 comment · May be fixed by #13594
Open

[substrait] make dependency on parquet optional #13593

notfilippo opened this issue Nov 28, 2024 · 1 comment · May be fixed by #13594
Assignees
Labels
enhancement New feature or request

Comments

@notfilippo
Copy link
Contributor

Is your feature request related to a problem or challenge?

The datafusion-substrait package currently depends on the datafusion crate with all default features enabled. This can force users that might want to use the substrait package to always have at least all the datafusion default features turned on.

Describe the solution you'd like

I propose that we hide parts of the datafusion-substrait crate that depend on datafusion's default feature behind some feature flags (enabled by default but that can be disabled by users)

Describe alternatives you've considered

No response

Additional context

No response

@notfilippo notfilippo added the enhancement New feature or request label Nov 28, 2024
@notfilippo
Copy link
Contributor Author

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant