Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CommonSubexprEliminate identifier management (10% faster planning) #10473

Merged
merged 10 commits into from
Jun 24, 2024
Merged

Improve CommonSubexprEliminate identifier management (10% faster planning) #10473

merged 10 commits into from
Jun 24, 2024

Commits on Jun 21, 2024

  1. implement hash based CSE identifier

    @peter-toth
    peter-toth committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    be59824 View commit details
    Browse the repository at this point in the history

  2. move is_volatile() check out of visitor

    @peter-toth
    peter-toth committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    fc71133 View commit details
    Browse the repository at this point in the history

  3. fix comments

    @peter-toth
    peter-toth committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    65c3676 View commit details
    Browse the repository at this point in the history

  4. add transformed asserts when rewrite_expr is called

    @peter-toth
    peter-toth committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    2c51d66 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. update MSRV to 1.76

    @peter-toth
    peter-toth committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    ccc92b9 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @peter-toth
    peter-toth committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    a0913aa View commit details
    Browse the repository at this point in the history

  3. better comments regarding volatile and short circuiting expressions

    @peter-toth
    peter-toth committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    d69033a View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. Merge branch 'main' into better-cse-identifier

    @peter-toth
    peter-toth committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    1a6f8e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into better-cse-identifier 

    # Conflicts:
#	datafusion/optimizer/src/common_subexpr_eliminate.rs
    @peter-toth
    peter-toth committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    ca8d095 View commit details
    Browse the repository at this point in the history

  3. address review comments

    @peter-toth
    peter-toth committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    ee61224 View commit details
    Browse the repository at this point in the history