Add user_defined_sql_planners(..) to FunctionRegistry #11296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
|
I'm ok with that as long as the register function neme (and I suppose deregister in the future) mirrors the naming scheme. I can file a followup issue to have that renamed. |
|
Rename update pushed. |
alamb
approved these changes
Jul 7, 2024
This was referenced Jul 7, 2024
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Add user_defined_sql_planners(..) to FunctionRegistry * Adding simple test for user_defined_sql_planners * Renamed user_defined_sql_planners to expr_planners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11294
Rationale for this change
Adding the ability to retrieve the list of registered user defined sql functions.
What changes are included in this PR?
Code, test.
Are these changes tested?
A simple test was added to verify api returns something.
Are there any user-facing changes?
FunctionRegistry trait was ammended.