Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: add example to of assert_batches_eq #12580

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 22, 2024

Which issue does this PR close?

N/A

Rationale for this change

While reviewing datafusion-contrib/datafusion-functions-extra#2 from @dmitrybugakov I realized there is no doc example of how to use this macro

What changes are included in this PR?

Add doc example

Are these changes tested?

Yes by doc ci

Are there any user-facing changes?

Only docs, no functional changes

@alamb alamb added the documentation Improvements or additions to documentation label Sep 22, 2024
@github-actions github-actions bot added common Related to common crate and removed documentation Improvements or additions to documentation labels Sep 22, 2024
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@comphead comphead merged commit 3978e5d into apache:main Sep 22, 2024
24 checks passed
@alamb alamb deleted the alamb/example_for_assert_batches_eq branch September 23, 2024 17:19
bgjackma pushed a commit to bgjackma/datafusion that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Related to common crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants