Upgrade arrow/parquet to `53.1.0` / fix clippy #12724

alamb · 2024-10-02T16:50:08Z

Which issue does this PR close?

Related to apache/arrow-rs#6340

Closes #3174

Rationale for this change

Fixes Clippy CI on main
Keep up with dependencies

~~I am creating this PR in advance as a way to test the arrow release candidate as well~~

What changes are included in this PR?

Upgrade arrow/parquet to 53.1.0
Switch to non-deprecated functions

Are these changes tested?

Are there any user-facing changes?

alamb · 2024-10-02T18:21:01Z

datafusion/core/src/datasource/file_format/parquet.rs

-            &suffix[metadata_start - footer_start..suffix_len - 8],
-        )?)
-    }
+    ParquetMetaDataReader::new()


We can finally have nice things -- this code is way simpler now thanks to all @etseidl's work upstream on apache/arrow-rs#6447

alamb · 2024-10-02T18:21:55Z

datafusion/sqllogictest/test_files/repartition_scan.slt

@@ -61,7 +61,7 @@ logical_plan
 physical_plan
 01)CoalesceBatchesExec: target_batch_size=8192
 02)--FilterExec: column1@0 != 42
-03)----ParquetExec: file_groups={4 groups: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:0..87], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:87..174], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:174..261], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:261..347]]}, projection=[column1], predicate=column1@0 != 42, pruning_predicate=CASE WHEN column1_null_count@2 = column1_row_count@3 THEN false ELSE column1_min@0 != 42 OR 42 != column1_max@1 END, required_guarantees=[column1 not in (42)]
+03)----ParquetExec: file_groups={4 groups: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:0..88], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:88..176], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:176..264], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/repartition_scan/parquet_table/2.parquet:264..351]]}, projection=[column1], predicate=column1@0 != 42, pruning_predicate=CASE WHEN column1_null_count@2 = column1_row_count@3 THEN false ELSE column1_min@0 != 42 OR 42 != column1_max@1 END, required_guarantees=[column1 not in (42)]


these files are slightly different sizes (larger) due to apache/arrow-rs#6490

alamb · 2024-10-02T18:23:59Z

datafusion/functions/src/regexp_common.rs

-// specific language governing permissions and limitations
-// under the License.
-
-//! Common utilities for implementing regex functions


@tlm365 ported this upstream to arrow-rs in apache/arrow-rs#6376 ❤️

alamb · 2024-10-02T19:46:57Z

datafusion/core/src/datasource/file_format/csv.rs

@@ -771,7 +771,7 @@ mod tests {
                "c7: Int64",
                "c8: Int64",
                "c9: Int64",
-                "c10: Int64",
+                "c10: Utf8",


This is due to apache/arrow-rs#6481 -- the fix for #3174 (see #3174 (comment))

alamb · 2024-10-02T20:25:21Z

datafusion/physical-expr/src/expressions/is_null.rs

@@ -103,65 +99,6 @@ impl PhysicalExpr for IsNullExpr {
    }
 }

-/// workaround <https://github.com/apache/arrow-rs/issues/6017>,


Use the implementation added in apache/arrow-rs#6303 from @gstvg

alamb · 2024-10-07T12:48:05Z

Thank you @tustvold

Omega359 · 2024-10-07T18:28:47Z

cargo-semver-checks would have been nice on a minor point release to not break existing usages.

alamb · 2024-10-07T19:36:47Z

cargo-semver-checks would have been nice on a minor point release to not break existing usages.

I think the 53.1.0 release was sem-ver compatible (at least we worked hard to make sure it was) 🤔

I would personally blame over zealous tests in DataFusion and using the latest / greatest dependencies as the reason for the CI failures, though I can see how that is a matter of perspective.

I don't think clippy warnings about deprecated methods is a breaking change (I realize it did break our CI but that is due to what we are testing)

The change in file sizes that caused the csv tests to fail was a bug fix, and you could argue that the DataFusion tests are more brittle than they should be (they have exact byte offests, so when they fail

Omega359 · 2024-10-07T19:52:53Z

I just realized I may have come across as snarky - not my intention at all. The only breaking change to me was the moving of decode_footer, decode_metadata to ParquetMetaDataReader. The clippy stuff is annoying but easily dealt with.

I am thinking that if arrow doesn't already have the cargo semver-checks (I haven't checked but suspect not) I may submit a PR to add it. Much better than complaining about it :)

alamb · 2024-10-07T20:49:33Z

No problems! I was mostly asking to make sure we hadn't messed up semver (and thus need to yank / publish a new version)

I am thinking that if arrow doesn't already have the cargo semver-checks (I haven't checked but suspect not) I may submit a PR to add it. Much better than complaining about it :)

that would be awesome 🙏

The only breaking change to me was the moving of decode_footer, decode_metadata to ParquetMetaDataReader. The clippy stuff is annoying but easily dealt with.

I just double checked and I think those functions still exist, but they are marked as deprecated:

Omega359 · 2024-10-07T20:51:37Z

I just double checked and I think those functions still exist, but they are marked as deprecated:
* https://docs.rs/parquet/latest/parquet/file/footer/fn.decode_footer.html

* https://docs.rs/parquet/latest/parquet/file/footer/fn.decode_metadata.html

Ah, my mistake! My memory isn't what it used to be :/

alamb · 2024-10-08T11:06:23Z

Ah, my mistake! My memory isn't what it used to be :/

😅 -- no problems. I was starting to freak out we released a breaking change in a minor arrow release

@etseidl

* Add support for external tables with qualified names (#12645) * Make support schemas * Set default name to table * Remove print statements and stale comment * Add tests for create table * Fix typo * Update datafusion/sql/src/statement.rs Co-authored-by: Jonah Gao <[email protected]> * convert create_external_table to objectname * Add sqllogic tests * Fix failing tests --------- Co-authored-by: Jonah Gao <[email protected]> * Fix Regex signature types (#12690) * Fix Regex signature types * Uncomment the shared tests in string_query.slt.part and removed tests copies everywhere else * Test `LIKE` and `MATCH` with flags; Remove new tests from regexp.slt * Refactor `ByteGroupValueBuilder` to use `MaybeNullBufferBuilder` (#12681) * Fix malformed hex string literal in docs (#12708) * Simplify match patterns in coercion rules (#12711) Remove conditions where unnecessary. Refactor to improve readability. * Remove aggregate functions dependency on frontend (#12715) * Remove aggregate functions dependency on frontend DataFusion is a SQL query engine and also a reusable library for building query engines. The core functionality should not depend on frontend related functionalities like `sqlparser` or `datafusion-sql`. * Remove duplicate license header * Minor: Remove clone in `transform_to_states` (#12707) * rm clone Signed-off-by: jayzhan211 <[email protected]> * fmt Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]> * Refactor tests for union sorting properties, add tests for unions and constants (#12702) * Refactor tests for union sorting properties * update doc test * Undo import reordering * remove unecessary static lifetimes * Fix: support Qualified Wildcard in count aggregate function (#12673) * Reduce code duplication in `PrimitiveGroupValueBuilder` with const generics (#12703) * Reduce code duplication in `PrimitiveGroupValueBuilder` with const generics * Fix docs * Disallow duplicated qualified field names (#12608) * Disallow duplicated qualified field names * Fix tests * Optimize base64/hex decoding by pre-allocating output buffers (~2x faster) (#12675) * add bench * replace macro with generic function * remove duplicated code * optimize base64/hex decode * Allow DynamicFileCatalog support to query partitioned file (#12683) * support to query partitioned table for dynamic file catalog * cargo clippy * split partitions inferring to another function * Support `LIMIT` Push-down logical plan optimization for `Extension` nodes (#12685) * Update trait `UserDefinedLogicalNodeCore` Signed-off-by: Austin Liu <[email protected]> * Update corresponding interface Signed-off-by: Austin Liu <[email protected]> Add rewrite rule for `push-down-limit` for `Extension` Signed-off-by: Austin Liu <[email protected]> * Add rewrite rule for `push-down-limit` for `Extension` and tests Signed-off-by: Austin Liu <[email protected]> * Update corresponding interface Signed-off-by: Austin Liu <[email protected]> * Reorganize to match guard Signed-off-by: Austin Liu <[email protected]> * Clena up Signed-off-by: Austin Liu <[email protected]> Clean up Signed-off-by: Austin Liu <[email protected]> --------- Signed-off-by: Austin Liu <[email protected]> * Fix AvroReader: Add union resolving for nested struct arrays (#12686) * Add union resolving for nested struct arrays * Add test * Change test * Reproduce index error * fmt --------- Co-authored-by: Andrew Lamb <[email protected]> * Adds macros for creating `WindowUDF` and `WindowFunction` expression (#12693) * Adds macro for udwf singleton * Adds a doc comment parameter to macro * Add doc comment for `create_udwf` macro * Uses default constructor * Update `Cargo.lock` in `datafusion-cli` * Fixes: expand `$FN_NAME` in doc strings * Adds example for macro usage * Renames macro * Improve doc comments * Rename udwf macro * Minor: doc copy edits * Adds macro for creating fluent-style expression API * Adds support for 1 or more parameters in expression function * Rewrite doc comments * Rename parameters * Minor: formatting * Adds doc comment for `create_udwf_expr` macro * Improve example docs * Hides extraneous code in doc comments * Add a one-line readme * Adds doc test assertions + minor formatting fixes * Adds common macro for defining user-defined window functions * Adds doc comment for `define_udwf_and_expr` * Defines `RowNumber` using common macro * Add usage example for common macro * Adds usage for custom constructor * Add examples for remaining patterns * Improve doc comments for usage examples * Rewrite inner line docs * Rewrite `create_udwf_expr!` doc comments * Minor doc improvements * Fix doc test and usage example * Add inline comments for macro patterns * Minor: change doc comment in example * Support unparsing plans with both Aggregation and Window functions (#12705) * Support unparsing plans with both Aggregation and Window functions (#35) * Fix unparsing for aggregation grouping sets * Add test for grouping set unparsing * Update datafusion/sql/src/unparser/utils.rs Co-authored-by: Jax Liu <[email protected]> * Update datafusion/sql/src/unparser/utils.rs Co-authored-by: Jax Liu <[email protected]> * Update * More tests --------- Co-authored-by: Jax Liu <[email protected]> * Fix strpos invocation with dictionary and null (#12712) In 1b3608d `strpos` signature was modified to indicate it supports dictionary as input argument, but the invoke method doesn't support them. * docs: Update DataFusion introduction to clarify that DataFusion does provide an "out of the box" query engine (#12666) * Update DataFusion introduction to show that DataFusion offers packaged versions for end users * change order * Update README.md Co-authored-by: Andrew Lamb <[email protected]> * refine wording and update user guide for consistency * prettier --------- Co-authored-by: Andrew Lamb <[email protected]> * Framework for generating function docs from embedded code documentation (#12668) * Initial work on #12432 to allow for generation of udf docs from embedded documentation in the code * Add missing license header. * Fixed examples. * Fixing a really weird RustRover/wsl ... something. No clue what happened there. * permission change * Cargo fmt update. * Refactored Documentation to allow it to be used in a const. * Add documentation for syntax_example * Refactoring Documentation based on PR feedback. * Cargo fmt update. * Doc update * Fixed copy/paste error. * Minor text updates. --------- Co-authored-by: Andrew Lamb <[email protected]> * Add IMDB(JOB) Benchmark [2/N] (imdb queries) (#12529) * imdb dataset * cargo fmt * Add 113 queries for IMDB(JOB) Signed-off-by: Austin Liu <[email protected]> * Add `get_query_sql` from `query_id` string Signed-off-by: Austin Liu <[email protected]> * Fix CSV reader & Remove Parquet partition Signed-off-by: Austin Liu <[email protected]> * Add benchmark IMDB runner Signed-off-by: Austin Liu <[email protected]> * Add `run_imdb` script Signed-off-by: Austin Liu <[email protected]> * Add checker for imdb option Signed-off-by: Austin Liu <[email protected]> * Add SLT for IMDB Signed-off-by: Austin Liu <[email protected]> * Fix `get_query_sql()` for CI roundtrip test Signed-off-by: Austin Liu <[email protected]> Fix `get_query_sql()` for CI roundtrip test Signed-off-by: Austin Liu <[email protected]> Fix `get_query_sql()` for CI roundtrip test Signed-off-by: Austin Liu <[email protected]> * Clean up Signed-off-by: Austin Liu <[email protected]> * Add missing license Signed-off-by: Austin Liu <[email protected]> * Add IMDB(JOB) queries `2b` to `5c` Signed-off-by: Austin Liu <[email protected]> * Add `INCLUDE_IMDB` in CI verify-benchmark-results Signed-off-by: Austin Liu <[email protected]> * Prepare IMDB dataset Signed-off-by: Austin Liu <[email protected]> Prepare IMDB dataset Signed-off-by: Austin Liu <[email protected]> * use uint as id type * format * Seperate `tpch` and `imdb` benchmarking CI jobs Signed-off-by: Austin Liu <[email protected]> Fix path Signed-off-by: Austin Liu <[email protected]> Fix path Signed-off-by: Austin Liu <[email protected]> Remove `tpch` in `imdb` benchmark Signed-off-by: Austin Liu <[email protected]> * Remove IMDB(JOB) slt in CI Signed-off-by: Austin Liu <[email protected]> Remove IMDB(JOB) slt in CI Signed-off-by: Austin Liu <[email protected]> --------- Signed-off-by: Austin Liu <[email protected]> Co-authored-by: DouPache <[email protected]> * Minor: avoid clone while calculating union equivalence properties (#12722) * Minor: avoid clone while calculating union equivalence properties * Update datafusion/physical-expr/src/equivalence/properties.rs * fmt * Simplify streaming_merge function parameters (#12719) * simplify streaming_merge function parameters * revert test change * change StreamingMergeConfig into builder pattern * Fix links on docs index page (#12750) * Provide field and schema metadata missing on cross joins, and union with null fields. (#12729) * test: reproducer for missing schema metadata on cross join * fix: pass thru schema metadata on cross join * fix: preserve metadata when transforming to view types * test: reproducer for missing field metadata in left hand NULL field of union * fix: preserve field metadata from right side of union * chore: safe indexing * Minor: Update string tests for strpos (#12739) * Apply `type_union_resolution` to array and values (#12753) * cleanup make array coercion rule Signed-off-by: jayzhan211 <[email protected]> * change to type union resolution Signed-off-by: jayzhan211 <[email protected]> * change value too Signed-off-by: jayzhan211 <[email protected]> * fix tpyo Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]> * Add `DocumentationBuilder::with_standard_argument` to reduce copy/paste (#12747) * Add `DocumentationBuilder::with_standard_expression` to reduce copy/paste * fix doc * fix standard argument * Update docs * Improve documentation to explain what is different * fix `equal_to` in `PrimitiveGroupValueBuilder` (#12758) * fix `equal_to` in `PrimitiveGroupValueBuilder`. * fix typo. * add uts. * reduce calling of `is_null`. * Minor: doc how field name is to be set (#12757) * Fix `equal_to` in `ByteGroupValueBuilder` (#12770) * Fix `equal_to` in `ByteGroupValueBuilder` * refactor null_equal_to * Update datafusion/physical-plan/src/aggregates/group_values/group_column.rs * Allow simplification even when nullable (#12746) The nullable requirement seem to have been added in #1401 but as far as I can tell they are not needed for these 2 cases. I think this can be shown using this truth table: (generated using datafusion-cli without this patch) ``` > CREATE TABLE t (v BOOLEAN) as values (true), (false), (NULL); > select t.v, t2.v, t.v AND (t.v OR t2.v), t.v OR (t.v AND t2.v) from t cross join t as t2; +-------+-------+---------------------+---------------------+ | v | v | t.v AND t.v OR t2.v | t.v OR t.v AND t2.v | +-------+-------+---------------------+---------------------+ | true | true | true | true | | true | false | true | true | | true | | true | true | | false | true | false | false | | false | false | false | false | | false | | false | false | | | true | | | | | false | | | | | | | | +-------+-------+---------------------+---------------------+ ``` And it seems Spark applies both of these and DuckDB applies only the first one. * Fix unnest conjunction with selecting wildcard expression (#12760) * fix unnest statement with wildcard expression * add commnets * Improve `round` scalar function unparsing for Postgres (#12744) * Postgres: enforce required `NUMERIC` type for `round` scalar function (#34) Includes initial support for dialects to override scalar functions unparsing * Document scalar_function_to_sql_overrides fn * Fix stack overflow calculating projected orderings (#12759) * Fix stack overflow calculating projected orderings * fix docs * Port / Add Documentation for `VarianceSample` and `VariancePopulation` (#12742) * Upgrade arrow/parquet to `53.1.0` / fix clippy (#12724) * Update to arrow/parquet 53.1.0 * Update some API * update for changed file sizes * Use non deprecated APIs * Use ParquetMetadataReader from @etseidl * remove upstreamed implementation * Update CSV schema * Use upstream is_null and is_not_null kernels * feat: add support for Substrait ExtendedExpression (#12728) * Add support for serializing and deserializing Substrait ExtendedExpr message * Address clippy reviews * Reuse existing rename method * Transformed::new_transformed: Fix documentation formatting (#12787) Co-authored-by: Andrew Lamb <[email protected]> * fix: Correct results for grouping sets when columns contain nulls (#12571) * Fix grouping sets behavior when data contains nulls * PR suggestion comment * Update new test case * Add grouping_id to the logical plan * Add doc comment next to INTERNAL_GROUPING_ID * Fix unparsing of Aggregate with grouping sets --------- Co-authored-by: Andrew Lamb <[email protected]> * Migrate documentation for all string functions from scalar_functions.md to code (#12775) * Added documentation for string and unicode functions. * Fixed issues with aliases. * Cargo fmt. * Minor doc fixes. * Update docs for var_pop/samp --------- Co-authored-by: Andrew Lamb <[email protected]> * Account for constant equivalence properties in union, tests (#12562) * Minor: clarify comment about empty dependencies (#12786) * Introduce Signature::String and return error if input of `strpos` is integer (#12751) * fix sig Signed-off-by: jayzhan211 <[email protected]> * fix Signed-off-by: jayzhan211 <[email protected]> * fix error Signed-off-by: jayzhan211 <[email protected]> * fix all signature Signed-off-by: jayzhan211 <[email protected]> * fix all signature Signed-off-by: jayzhan211 <[email protected]> * change default type Signed-off-by: jayzhan211 <[email protected]> * clippy Signed-off-by: jayzhan211 <[email protected]> * fix docs Signed-off-by: jayzhan211 <[email protected]> * rm deadcode Signed-off-by: jayzhan211 <[email protected]> * cleanup Signed-off-by: jayzhan211 <[email protected]> * cleanup Signed-off-by: jayzhan211 <[email protected]> * rm test Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]> * Minor: improve docs on MovingMin/MovingMax (#12790) * Add slt tests (#12721) --------- Signed-off-by: jayzhan211 <[email protected]> Signed-off-by: Austin Liu <[email protected]> Co-authored-by: OussamaSaoudi <[email protected]> Co-authored-by: Jonah Gao <[email protected]> Co-authored-by: Dmitrii Blaginin <[email protected]> Co-authored-by: Andrew Lamb <[email protected]> Co-authored-by: Tomoaki Kawada <[email protected]> Co-authored-by: Piotr Findeisen <[email protected]> Co-authored-by: Jay Zhan <[email protected]> Co-authored-by: HuSen <[email protected]> Co-authored-by: Emil Ejbyfeldt <[email protected]> Co-authored-by: Simon Vandel Sillesen <[email protected]> Co-authored-by: Jax Liu <[email protected]> Co-authored-by: Austin Liu <[email protected]> Co-authored-by: JonasDev1 <[email protected]> Co-authored-by: jcsherin <[email protected]> Co-authored-by: Sergei Grebnov <[email protected]> Co-authored-by: Andy Grove <[email protected]> Co-authored-by: Bruce Ritchie <[email protected]> Co-authored-by: DouPache <[email protected]> Co-authored-by: mertak-synnada <[email protected]> Co-authored-by: Bryce Mecum <[email protected]> Co-authored-by: wiedld <[email protected]> Co-authored-by: kamille <[email protected]> Co-authored-by: Weston Pace <[email protected]> Co-authored-by: Val Lorentz <[email protected]>

github-actions bot added functions sqllogictest SQL Logic Tests (.slt) physical-expr Physical Expressions core Core DataFusion crate labels Oct 2, 2024

alamb commented Oct 2, 2024

View reviewed changes

alamb force-pushed the alamb/prep_53.1.0 branch from 4c03f29 to f66be51 Compare October 2, 2024 20:23

alamb mentioned this pull request Oct 2, 2024

Support IS NULL and IS NOT NULL on Unions #11321

Merged

alamb commented Oct 2, 2024

View reviewed changes

alamb mentioned this pull request Oct 2, 2024

Release arrow-rs / parquet minor version 53.1.0 (October 2024) apache/arrow-rs#6340

Closed

3 tasks

alamb force-pushed the alamb/prep_53.1.0 branch 2 times, most recently from dbee260 to c907829 Compare October 3, 2024 10:42

This was referenced Oct 4, 2024

Release DataFusion 43.0.0 #12470

Closed

Enable reading StringViewArray by default from Parquet #12092

Closed

alamb changed the title ~~WIP: Upgrade arrow/parquet to 53.1.0~~ Upgrade arrow/parquet to 53.1.0 Oct 5, 2024

alamb force-pushed the alamb/prep_53.1.0 branch from c907829 to 80c24dc Compare October 5, 2024 10:23

alamb added 8 commits October 7, 2024 06:45

Update to arrow/parquet 53.1.0

42a63fe

Update some API

ab09269

update for changed file sizes

27e8244

Use non deprecated APIs

2792b11

Use ParquetMetadataReader from @etseidl

9ba1dc3

remove upstreamed implementation

a081a60

Update CSV schema

1b99197

Use upstream is_null and is_not_null kernels

49eeb88

alamb force-pushed the alamb/prep_53.1.0 branch from 80c24dc to 49eeb88 Compare October 7, 2024 10:45

alamb marked this pull request as ready for review October 7, 2024 10:45

This was referenced Oct 7, 2024

Chore: Move aggregate statistics optimizer test from core to optimizer crate #12783

Merged

Transformed::new_transformed: Fix documentation formatting #12787

Merged

This was referenced Oct 7, 2024

Minor: clarify comment about empty dependencies #12786

Merged

Account for constant equivalence properties in union, tests #12562

Merged

alamb changed the title ~~Upgrade arrow/parquet to 53.1.0~~ Upgrade arrow/parquet to 53.1.0 / fix clippy Oct 7, 2024

alamb mentioned this pull request Oct 7, 2024

fix: Correct results for grouping sets when columns contain nulls #12571

Merged

tustvold approved these changes Oct 7, 2024

View reviewed changes

alamb merged commit 9d8f77d into apache:main Oct 7, 2024
29 checks passed

alamb deleted the alamb/prep_53.1.0 branch October 7, 2024 12:48

alamb mentioned this pull request Oct 7, 2024

Migrate documentation for all string functions from scalar_functions.md to code #12775

Merged

Omega359 mentioned this pull request Oct 7, 2024

Arrow update to 53.1.0 caused clippy issues with missing and deprecated methods and test failures #12780

Closed

This was referenced Oct 16, 2024

Backport "Provide field and schema metadata missing on cross joins, and union with null fields" (#12729) #12974

Merged

Backport update to arrow 53.1.0 on branch-42 #12977

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade arrow/parquet to `53.1.0` / fix clippy #12724

Upgrade arrow/parquet to `53.1.0` / fix clippy #12724

alamb commented Oct 2, 2024 •

edited

Loading

alamb Oct 2, 2024

alamb Oct 2, 2024

alamb Oct 2, 2024

alamb Oct 2, 2024

alamb Oct 2, 2024

alamb commented Oct 7, 2024

Omega359 commented Oct 7, 2024

alamb commented Oct 7, 2024

Omega359 commented Oct 7, 2024

alamb commented Oct 7, 2024

Omega359 commented Oct 7, 2024

alamb commented Oct 8, 2024

Upgrade arrow/parquet to 53.1.0 / fix clippy #12724

Upgrade arrow/parquet to 53.1.0 / fix clippy #12724

Conversation

alamb commented Oct 2, 2024 • edited Loading

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

alamb Oct 2, 2024

Choose a reason for hiding this comment

alamb Oct 2, 2024

Choose a reason for hiding this comment

alamb Oct 2, 2024

Choose a reason for hiding this comment

alamb Oct 2, 2024

Choose a reason for hiding this comment

alamb Oct 2, 2024

Choose a reason for hiding this comment

alamb commented Oct 7, 2024

Omega359 commented Oct 7, 2024

alamb commented Oct 7, 2024

Omega359 commented Oct 7, 2024

alamb commented Oct 7, 2024

Omega359 commented Oct 7, 2024

alamb commented Oct 8, 2024

Upgrade arrow/parquet to `53.1.0` / fix clippy #12724

Upgrade arrow/parquet to `53.1.0` / fix clippy #12724

alamb commented Oct 2, 2024 •

edited

Loading