Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research pulling in more useful patches not included in upstream #21

Open
4 of 9 tasks
apainintheneck opened this issue Feb 5, 2024 · 2 comments
Open
4 of 9 tasks
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@apainintheneck
Copy link
Owner

apainintheneck commented Feb 5, 2024

The main Linenoise repo is somewhat abandoned. Though it provided a good foundation it has a large number of bug reports and pending fixes/improvements. Some of those pending fixes and improvements might be useful to add to this repo in a pinch. That is especially true for bug fixes.

Potential Fixes

Potential Improvements

It might also be interesting to look at some forks to see if they have any changes we can pull in that would be useful.

Linenoise Forks

@apainintheneck apainintheneck added enhancement New feature or request help wanted Extra attention is needed labels Feb 5, 2024
@apainintheneck
Copy link
Owner Author

I ran into the ANSI escape sequence prompt bug recently while working on apainintheneck/gitsh#1.

@apainintheneck
Copy link
Owner Author

apainintheneck commented Feb 6, 2024

Note: The cursor position bug was only fixed for single line mode by #22. It would be nice to add a fix for multiline mode as well though that would be a bit more complex.

Edit: The cursor position bug has been fixed for single and multiline mode by #27.

@apainintheneck apainintheneck mentioned this issue Feb 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant