Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multi-valued headers #15

Open
odusseys opened this issue Jan 7, 2019 · 2 comments
Open

Support for multi-valued headers #15

odusseys opened this issue Jan 7, 2019 · 2 comments

Comments

@odusseys
Copy link

odusseys commented Jan 7, 2019

AWS added support for multiple-valued headers see here

We will be forking as this is urgent for us, but will probably submit a PR if our solution works.

@piotrkubisa
Copy link

piotrkubisa commented Jun 20, 2019

If you like forks then I've prepared one for you https://github.com/piotrkubisa/apigo 😛

I've forked the apex/gateway, implemented multi-value query strings, headers, introduced new event-to-http.Request conversion algorithm that is easier to customize, also done some profiling and squashed some allocations and nanoseconds needed for L7 proxy, as you can see in following benchmark (https://gist.github.com/piotrkubisa/03e04aaa8a4c5992189c556596f12689).

@tj
Copy link
Member

tj commented Jun 21, 2019

not too worried about the performance side of things, if you use API Gateway for that kind of traffic it's going to be like 1000x the cost of running on EC2 :D, happy to merge a PR for the multi-header stuff if anyone needs it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants