Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Quote: "USDUSD" is missing #16

Open
danielmarschall opened this issue Aug 6, 2022 · 5 comments
Open

Quote: "USDUSD" is missing #16

danielmarschall opened this issue Aug 6, 2022 · 5 comments

Comments

@danielmarschall
Copy link

Hello,

I noticed that in CurrencyLayer, the quote entry "USDUSD" is missing. It should have the value 1.
My OpenSource software relied on this value and due to the change at CurrencyLayers, the apps don't work anymore.
Can you please re-add it again? Thank you.

Best regards,
Daniel Marschall

PS: I tried to contact via https://currencylayer.com/contact but I get the error message "Unable to create support ticket.".

danielmarschall added a commit to danielmarschall/currency_converter that referenced this issue Aug 6, 2022
64 bit Demo EXE now uses Visual Themes

git-svn-id: https://svn.viathinksoft.com/svn/currency_converter/trunk@22 329da09e-376f-4659-9b51-cf1fc02ac161
@richardbiddle
Copy link

All conversions where source and destination are the same have been removed as well. It could be due to the issue mentioned above #14 and #15

@danielmarschall
Copy link
Author

danielmarschall commented Aug 8, 2022

Of course, the entry "USDUSD" must always be 1 . The other bug reports reported that the value is not equal 1, which is clearly wrong. It is unfortunate for me that the bugfix was to remove "USDUSD" instead of hard-coding it to value 1. Backwards compatibility should be a number 1 goal for any API developer.

But I have added a workaround to my library. However, I hope there aren't too much of my users affected (my OpenSource middleware is 900 times downloaded. I have no idea who is actively using it, though).

Side note: I want to explain why the lack of "USDUSD" broke my code. I had to get a list of all currencies, and to get it, I simply listed all quotes and extracted the last 3 bytes of each entry. With "USDUSD" missing, I didn't got USD as currency.

@NikolaosWakem
Copy link

This random change just made my day not fun too!

@ikottman
Copy link

This is a breaking change to the API contract. The hardcoding of 1 should be done on the API side to maintain backwards compatibility.

@cyrnetix
Copy link

Please put USDUSD back with a constant value of 1. This a breaking change which screwed up my day and a lot of my colleagues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants