Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoSuchMethodError in runecrafting plugin #403

Open
wants to merge 1 commit into
base: kotlin-experiments
Choose a base branch
from

Conversation

rmcmk
Copy link
Contributor

@rmcmk rmcmk commented Jul 22, 2018

java.lang.NoSuchMethodError: Runecrafting_plugin.access$getChangeAltarObjectConfigId$p(LRunecrafting_plugin;)I
	at Runecrafting_plugin$2.invoke(runecrafting.plugin.kts:13)
	at Runecrafting_plugin$2.invoke(runecrafting.plugin.kts:3)
	at org.apollo.game.plugin.kotlin.KotlinPlayerHandlerProxyTrait$DefaultImpls.handleProxy(KotlinPluginScript.kt:92)
	at org.apollo.game.plugin.kotlin.KotlinPlayerEventHandler.handleProxy(KotlinPluginScript.kt:101)
	at org.apollo.game.plugin.kotlin.KotlinPlayerEventHandler.handleProxy(KotlinPluginScript.kt:101)
	at org.apollo.game.plugin.kotlin.KotlinPlayerEventHandler.handle(KotlinPluginScript.kt:107)
	at org.apollo.game.plugin.kotlin.KotlinPlayerEventHandler.handle(KotlinPluginScript.kt:101)
	at org.apollo.game.model.event.EventListenerChain.notify(EventListenerChain.java:52)
	at org.apollo.game.model.event.EventListenerChainSet.notify(EventListenerChainSet.java:27)
	at org.apollo.game.model.World.submit(World.java:336)
	at org.apollo.game.model.entity.Player.sendInitialMessages(Player.java:759)
	at org.apollo.game.service.GameService.finalizePlayerRegistration(GameService.java:128)
	at org.apollo.game.service.GameService.finalizeRegistrations(GameService.java:222)
	at org.apollo.game.service.GameService.pulse(GameService.java:154)
	at org.apollo.game.GamePulseHandler.run(GamePulseHandler.java:37)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

@tlf30
Copy link
Contributor

tlf30 commented Jul 23, 2018

Sorry, that was my fault. Thank you for finding and fixing that.

@garyttierney
Copy link
Contributor

garyttierney commented Jul 23, 2018

I still don't understand why we're hitting this in the first place. Is this a code-gen bug [in Kotlin]?

@tlf30
Copy link
Contributor

tlf30 commented Jul 23, 2018

Im not sure, it is odd. I was sure this was working before.

@garyttierney
Copy link
Contributor

Looks like a regression in kotlinc. We should report this to the Kotlin team.

@garyttierney garyttierney self-requested a review July 23, 2018 17:01
@Major-
Copy link
Member

Major- commented Jul 23, 2018

AFAIK this has never worked so it's technically not a regression (but is definitely a bug)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants