Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler "ok" snapshot tests should store high level representation instead of ast #687

Closed
lrlna opened this issue Oct 10, 2023 · 0 comments · Fixed by #695
Closed

compiler "ok" snapshot tests should store high level representation instead of ast #687

lrlna opened this issue Oct 10, 2023 · 0 comments · Fixed by #695
Assignees
@SimonSapin
Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation

Comments

@lrlna
Copy link
Member

lrlna commented Oct 10, 2023

I was writing a test for implicit schema definitions we are now handling in #678, and realised there is no way to compare that a schema definition exists from our snapshot tests. It'd be useful to see that with type Query { name: String } compiler's document representation indeed contains a schema definition in snapshots.
@lrlna lrlna added the apollo-compiler issues/PRs pertaining to semantic analysis & validation label Oct 10, 2023
@SimonSapin SimonSapin mentioned this issue Oct 12, 2023
Merged
@SimonSapin SimonSapin self-assigned this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonSapin SimonSapin

Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Snapshot tests: Debug output of Schema+ExecutableDocument instead of AST apollographql/apollo-rs
2 participants
@SimonSapin @lrlna