Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adopt_orphan_extensions opt in flag + allow extending implicit schema #678

Merged
merged 3 commits into from
Oct 10, 2023
Merged

adopt_orphan_extensions opt in flag + allow extending implicit schema #678

merged 3 commits into from
Oct 10, 2023

Conversation

SimonSapin
Copy link
Contributor

@SimonSapin SimonSapin commented Oct 6, 2023 •
edited
Loading

Fixes #682

@SimonSapin SimonSapin self-assigned this Oct 6, 2023
@SimonSapin SimonSapin changed the title Add opt in flag to adopt orphan extensions adopt_orphan_extensions opt in flag + allow extending implicit schema Oct 10, 2023
@SimonSapin SimonSapin marked this pull request as ready for review October 10, 2023 10:26
@lrlna lrlna mentioned this pull request Oct 10, 2023
Closed
lrlna
lrlna approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i added a few snapshot tests to encapsulate some of this work

crates/apollo-compiler/src/schema/from_ast.rs
/// Configure the builder so that “orphan” schema extensions and type extensions
/// (without a corresponding definition) are “adopted”:
/// accepted as if extending an empty definition instead of being rejected as errors.
pub fn adopt_orphan_extensions(mut self) -> Self {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a+ naming

@SimonSapin SimonSapin merged commit 5065bc7 into compiler-v1.0 Oct 10, 2023
@SimonSapin SimonSapin deleted the adopted-extensions branch October 10, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrlna lrlna lrlna approved these changes

@goto-bus-stop goto-bus-stop Awaiting requested review from goto-bus-stop goto-bus-stop is a code owner

Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonSapin @lrlna