Skip to content

Commit

Permalink
Fix Windows Installer Bug When No Arguments Presented & Add Testing T…
Browse files Browse the repository at this point in the history
…o Ensure No Regressions (#1975)

Fixes: #1928 

It seems that in certain situations whitespace is getting passed into
the script and messing up the Rover install command. This fixes that by
filtering out whitespace if it gets passed in.
  • Loading branch information
jonathanrainer authored Aug 29, 2024
1 parent 9029d45 commit af387a3
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion installers/binstall/scripts/windows/install.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ function Download($version) {
}

function Invoke-Installer($tmp, $rover_install_args) {
& "$exe" "install" "$rover_install_args"
if (![string]::IsNullOrWhiteSpace($rover_install_args)) {
& "$exe" "install" "$rover_install_args"
} else {
& "$exe" "install"
}
Remove-Item "$tmp" -Recurse -Force
}

Expand Down

0 comments on commit af387a3

Please sign in to comment.