Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Kotlin inventory subgraph needs open telemetry tracing support #67

Open
prasek opened this issue Mar 15, 2022 · 4 comments
Open

New Kotlin inventory subgraph needs open telemetry tracing support #67

prasek opened this issue Mar 15, 2022 · 4 comments
Assignees

Comments

@prasek
Copy link
Contributor

prasek commented Mar 15, 2022

The previous NodeJS inventory subgraph supported otel tracing, so we need to add the same for the Kotlin port.

Demo instructions should work as before: https://github.com/apollographql/supergraph-demo-fed2#tracing-with-open-telemetry

Something similar to previous Node inventory service would be ideal so it just slots into the existing https://github.com/apollographql/supergraph-demo-fed2/blob/main/docker-compose.otel-collector.yml

@prasek prasek assigned prasek and martinbonnin and unassigned prasek Mar 15, 2022
@martinbonnin
Copy link
Contributor

Thanks for noticing this! Looks like we're going to need open-telemetry/opentelemetry-java-instrumentation#4270

I'm pretty new to all of this so it may take some time. Feel free to revert the inventory service to NodeJS until we figure this out.

@prasek
Copy link
Contributor Author

prasek commented Mar 16, 2022

/cc @hwillson @lennyburdette

@prasek
Copy link
Contributor Author

prasek commented Jan 5, 2023

@dariuszkuc @korinne is it relatively easy to add the java otel support here to bring this back to parity? do you have suggestions on what libs to use or examples we should follow?

@dariuszkuc
Copy link
Member

Since we are using Spring we probably should use their suggested library -> micrometer tracing (formerly known as Spring Cloud Sleuth). AFAIK it should "just work" - i.e. generate trace per HTTP request.

Unsure what extra information would open-telemetry lib bring (or even whether it is necessary) but we could probably try adding that as well. Looks like it parses the request to get some basic info - depending on how they implemented it I'm guessing it might be adding some processing overhead (e.g. naive solution would be to parse the request body in the webfilter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants