Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat receiving HEADERS for a new stream after sending a GOAWAY as a stream error #466

Open
glbrntt opened this issue Oct 15, 2024 · 0 comments · May be fixed by #481
Open

Treat receiving HEADERS for a new stream after sending a GOAWAY as a stream error #466

glbrntt opened this issue Oct 15, 2024 · 0 comments · May be fixed by #481
Labels
kind/bug Feature doesn't work as expected.

Comments

@glbrntt
Copy link
Contributor

glbrntt commented Oct 15, 2024

In #457 the behaviour when receiving a HEADERS frame for a new stream when fully quiesced was changed from a connection error to a stream error.

This was necessary because a client creating a new stream can race with the server sending a GOAWAY which currently results in a connect level error (which in turn typically results in the connection being closed and all in-flight requests being dropped).

However, this behaviour change should also apply to the locally quiescing state. At the moment the following can happen:

  • Client sends HEADERS frame for new stream
  • Server sends GOAWAY frame
  • Server receives HEADERS frame for new stream
    • throws a NoSuchStreamError which is treated as a connection-level error
    • results in another GOAWAY frame with a protocolError being sent and the error being fired down the channel pipeline

ChannelHandler's reacting to errors can't distinguish between the client incorrectly implementing the protocol (i.e. a genuine NoSuchStream error) vs. a race between the server locally quiescing and the client creating a new stream.

This should instead be treated as a stream error like in #457.

@glbrntt glbrntt added the kind/bug Feature doesn't work as expected. label Oct 15, 2024
@glbrntt glbrntt linked a pull request Nov 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Feature doesn't work as expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant