Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create: Fix proxies consuming all gas on failure #244

Open
izqui opened this issue Dec 7, 2020 · 4 comments
Open

Create: Fix proxies consuming all gas on failure #244

izqui opened this issue Dec 7, 2020 · 4 comments
Assignees
@izqui
Labels
Blocked/Frozen Label to mark a PR as blocked or frozen Discussion P0 🚒 'Drop everything and work on this' issues T0: Core 🌞 Core issues

Comments

@izqui
Copy link
Contributor

izqui commented Dec 7, 2020

Probably executing invalid instead of revert on failure. Will require editing the bytecode for the proxies
@izqui izqui self-assigned this Dec 7, 2020
@izqui izqui added P0 🚒 'Drop everything and work on this' issues S2: Bug 👩‍✈️ Squash them all T0: Core 🌞 Core issues labels Dec 7, 2020
@izqui
Copy link
Contributor Author

izqui commented Dec 7, 2020

Related to #239

@sohkai
Copy link
Contributor

sohkai commented Dec 8, 2020

From EIP1167, the bytecode contained in the proxies don't include any invalid opcodes so I don't think that's the case.

However, the proxies previous to #252 were computing the proxy creation bytecode incorrectly, potentially leading to this behaviour.

@izqui
Copy link
Contributor Author

izqui commented Dec 8, 2020

Makes sense, will test later

@novaknole
Copy link
Contributor

I couldn't reproduce the INVALID opcode execution. Tried the proxy bytecode creation before #252 and after #252. Still, nothing.

Would be good if you could write the steps how to reproduce it.

@nivida nivida added Blocked/Frozen Label to mark a PR as blocked or frozen Discussion and removed S2: Bug 👩‍✈️ Squash them all labels Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@izqui izqui

Labels
Blocked/Frozen Label to mark a PR as blocked or frozen Discussion P0 🚒 'Drop everything and work on this' issues T0: Core 🌞 Core issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@izqui @nivida @sohkai @novaknole