Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console: Checking actions before scheduling #514

Open
heueristik opened this issue Jan 4, 2022 · 0 comments
Open

Console: Checking actions before scheduling #514

heueristik opened this issue Jan 4, 2022 · 0 comments
Labels
P1 🔜 'We need to do this ASAP' issues S1: Feature 👨‍🎨 Adding new stuff T1: App 📱 User-facing issues

Comments

@heueristik
Copy link

Problem

Scheduling an optimistic action with an execution delay of several days and finding out that it cannot be executed is a very frustrating experience.

This can have two reasons:

  • internal contract state, e.g.,
    • the token balance is too low
    • a user role is wrong
  • external contract state, e.g.,
    • ERC-20 allowances are not set

This can lead to a large delay if one or multiple mitigating actions need to be scheduled and/or, worse, to the loss of the collateral.
The latter happened frequently, and more than 350 ANT are irretrievably lost by the time of writing.

Solution

  • The action should be checked before sending it.
  • On failure, It should display a verbose warning. This could be the revert string or, even better, additional information how to fix this issue for common pitfalls such as ERC-20 allowances, insufficient balance, etc.
  • It should still be allowed to schedule the action because the state could be correct at the time of execution.
@heueristik heueristik added P1 🔜 'We need to do this ASAP' issues T1: App 📱 User-facing issues S1: Feature 👨‍🎨 Adding new stuff labels Jan 4, 2022
@heueristik heueristik changed the title Checking actions before scheduling Govern UI: Checking actions before scheduling Jan 4, 2022
@heueristik heueristik changed the title Govern UI: Checking actions before scheduling Console: Checking actions before scheduling Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 🔜 'We need to do this ASAP' issues S1: Feature 👨‍🎨 Adding new stuff T1: App 📱 User-facing issues
Projects
None yet
Development

No branches or pull requests

1 participant