Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface injections defined in common project should also applies to platform project. #112

Open
Luna5ama opened this issue Dec 12, 2022 · 2 comments

Comments

@Luna5ama
Copy link

I have interface injections defined in the common project's fabric.mod.json, loom did apply it to the mc jar for that project as intended. However, it didn't apply the same injections for the platform projects(fabric and forge). It would be great if it can be done automatically, so it is also possible to use the interface methods in the platform projects.
Loom version: 1.0.304 (latest)
image

@Juuxel
Copy link
Member

Juuxel commented Dec 12, 2022

This is more of an upstream issue (applying IIs from other Gradle projects in the same build), I don't know if Fabric has planned support for this.

The project layout handling (common+fabric+forge) isn't actually part of Loom but Architectury Plugin, but even there the layout is actually mostly declared using dependencies instead of some proper structure that could automatically discover the interfaces and other stuff like AWs.

@Juuxel
Copy link
Member

Juuxel commented Feb 19, 2023

I believe Loom 1.1 has support for this:

Jar processor inputs such as interface injection or access wideners are now also read from project dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants