Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forgeRuntimeLibrary does not work for certain dependencies with NeoForge #248

Open
stewi1014 opened this issue Nov 19, 2024 · 0 comments
Open

Comments

@stewi1014
Copy link

stewi1014 commented Nov 19, 2024

Some dependencies cannot be found when running NeoForge despite using forgeRuntimeLibrary.

Steps to reproduce:

  • add org.apache.sshd:sshd-common to build.gradle
  • import it in code
  • execute the 'runServer' run configuration

References to the library will throw java.lang.ClassNotFoundException.
This does not happen with the shadow jar, does not happen under fabric and only seems to happen for some libraries.

I've created a repo from https://generate.architectury.dev/ that reproduces the issue: stewi1014/architectury-import-test@d8f3e80

Edit: Just realized the generator used 1.6-SNAPSHOT version of Architectury Loom, but there's no change when using 1.7-SNAPSHOT. I originally had this issue in a mod using 1.7-SNAPSHOT.

stewi1014 added a commit to stewi1014/fastback that referenced this issue Nov 19, 2024
I don't currently have a solution for the problem this was solving, but moving to org.apache.sshd has broken this fix.

ModDevGradle works, so it seems this is an issue with architectury-loom. Issue architectury/architectury-loom#248

This means that ssh will be unavailable in the dev environment.
stewi1014 added a commit to stewi1014/fastback that referenced this issue Nov 20, 2024
…rt in fasback-forge'

At-least I believe it does. Uploading was failing with a jgit error aboud failing to negotiate the algorithm.
Uploading to gitea and github now work after this change, which indicates to me that this issue is resolved.

However, org.apache.sshd goes missing in development environments, and the SshHacks fix does not work anymore because of the library change.
I've made an issue in architectury-loom for this: architectury/architectury-loom#248

In addition, the error thrown due to org.apache.sshd going missing is now being logged, but will not prevent fastback from loading.
Allowing the development environment to still be used without support for ssh.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant