Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Architectury API where a Forge port does not exist #25

Open
wants to merge 6 commits into
base: feature/forge-1.20.6-1.21
Choose a base branch
from

Conversation

cassiancc
Copy link
Contributor

This is a PR to improve #19 by adding support for disabling Architectury API on versions of LexForge where Architectury API is not available.

Copy link
Member

@Juuxel Juuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good 👍

Please follow the existing code format (semicolons at the end of the line and } else { on one line).

res/script.js Outdated Show resolved Hide resolved
src/web.rs Outdated Show resolved Hide resolved
src/web.rs Outdated Show resolved Hide resolved
@cassiancc
Copy link
Contributor Author

Code format changes should now be resolved. Thanks for the feedback.

@cassiancc cassiancc requested a review from Juuxel December 6, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants