Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect library editing & enable warnings #1826

Open
PaulStoffregen opened this issue Sep 13, 2018 · 2 comments
Open

Detect library editing & enable warnings #1826

PaulStoffregen opened this issue Sep 13, 2018 · 2 comments
Assignees
Labels
criticality: low Of low impact topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@PaulStoffregen
Copy link

Perhaps arduino-builder could detect when someone is editing a library's files, rather than just using an installed copy. This might be done by comparing timestamps on library source files to library.properties or other non-source files. Or maybe the presence of a .git folder is enough?

The idea would be to turn on all compiler warnings when building that library. Ordinary users would not be bothered, and library authors would not be bothered by warnings from other libraries, only their's.

Over time, this could lead to a significant improvement in the quality of library code over the entire Arduino ecosystem.

Previously mentioned here.

@facchinm
Copy link
Member

Completely agree but I'm not sure how we should achieve this; presence of .git folder could be a good candidate but the best would be also tracking if the repo is "dirty". However, in this case the switch wouldn't trigger if you commit before testing 🙂

@rsora
Copy link
Contributor

rsora commented Oct 21, 2021

@rsora rsora added the priority: low Resolution is a low priority label Oct 21, 2021
@rsora rsora assigned ubidefeo and cmaglie and unassigned silvanocerza Oct 21, 2021
@rsora rsora added criticality: low Of low impact and removed priority: low Resolution is a low priority labels Nov 2, 2021
@per1234 per1234 transferred this issue from arduino/arduino-builder Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: low Of low impact topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

7 participants