Add GitHub CI #12
Open
Add GitHub CI #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of changes: - code format to Elixir 1.17 - remove unused deps - resolve issue with Erlang OTP 27
kianmeng
commented
Aug 19, 2024
| @@ -34,15 +34,16 @@ defmodule Sizeable do | |||
| filesize(parsed, options) | |||
| end | |||
|
|
|||
| def filesize(0.0, options) do | |||
| def filesize(+0.0, options) do | |||
| spacer = Keyword.get(options, :spacer, " ") | |||
There was a problem hiding this comment.
warning: pattern matching on 0.0 is equivalent to matching only on +0.0 from Erlang/OTP 27+. Instead you must match on +0.0 or -0.0
└─ lib/sizeable.ex: Sizeable.filesize/2
kianmeng
commented
Aug 19, 2024
| ] | ||
| end | ||
|
|
||
| defp deps do | ||
| [ | ||
| {:ex_doc, ">= 0.0.0", only: :dev, runtime: false}, | ||
| {:inch_ex, only: :docs} |
There was a problem hiding this comment.
Since we're not using Inch, remove this.
kianmeng
commented
Aug 19, 2024
| matrix: | ||
| include: | ||
| - pair: | ||
| elixir: 1.11.x |
There was a problem hiding this comment.
I still retain the support of Elixir 1.11.x, not sure if we want to bump to 1.13, which is the minimal version that still have security support.,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes: