Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jacket else #7

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Jacket else #7

wants to merge 9 commits into from

Conversation

Hannes-III
Copy link

I added the discussed function jacket-else() to the code base and added the documentation.
Going through the code I found some places where I thought I should change something else.
The most unsure change was done in my first commit where I removed unnecessary code. It was not documented and seamed to me as a leftover from a former concept.
I hope those changes do not interfere with your ideas for your project and would be glad to see them accepted.
If you need some Changes that I Should still do, please let me know.

Regards, Hannes

accidential match because we add a null value to the Jacket list in
certain cases.
index() will change from "false" to "null" in future versions of Sass.
For compatibility, avoid using "== false" on the return value. For
example, instead of "@if index(...) == false", just write
"@if not index(...)".
Variable to prevent mistakes.
The Check "If jacket is a single context and selector list,
encapsulate." was only done in the Mixin but not in 
the Function.
To add a context to an existing Jacket Variable was not easy to not
destroy the consistency of the list. Therefor I created this function.
It will return $value if the $contexts match or $else if not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants