Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle state params in oauthGoogleEventHandler #178

Closed
julianfox opened this issue Sep 16, 2024 · 4 comments
Closed

Handle state params in oauthGoogleEventHandler #178

julianfox opened this issue Sep 16, 2024 · 4 comments

Comments

@julianfox
Copy link
Contributor

It seems that the oauthGoogleEventHandler doesn't support passing a state parameter during the OAuth flow ?

Here more information from the docs:
https://developers.google.com/identity/protocols/oauth2/web-server#request-parameter-state

@julianfox
Copy link
Contributor Author

@julianfox
Copy link
Contributor Author

julianfox commented Sep 17, 2024

I confirm that my fork works as intended.

To integrate it into my code:
I copied and pasted my version of oauth/google.ts into server/utils/oauth/google.ts, renaming OAuthGoogleConfig to OauthGoogleStateConfig and oauthGoogleEventHandler to oauthGoogleStateEventHandler.
I also had to copy and paste server/lib/utils.ts into the server/utils/oauth folder.

Is there a better way to extend handlers in our code?

Copy link
Owner

atinux commented Sep 25, 2024

Why not opening a PR to add this feature?

@julianfox
Copy link
Contributor Author

@atinux sure! #192

@atinux atinux closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants