Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement id hydration and custom hydration definitions #635

Open
wants to merge 2 commits into
base: improve-schema-traverser
Choose a base branch
from
Open

Implement id hydration and custom hydration definitions #635

wants to merge 2 commits into from

Conversation

gnawf
Copy link
Collaborator

@gnawf gnawf commented Nov 27, 2024

No description provided.

@github-actions GitHub Actions
Copy link

Test Results

  132 files  +1  132 suites  +1   55s ⏱️ +3s
  996 tests +2  931 ✅ ±0  65 💤 +2  0 ❌ ±0 
1 004 runs  +2  939 ✅ ±0  65 💤 +2  0 ❌ ±0 

Results for commit b0cf2ca. ± Comparison against base commit 7127058.

This was referenced Nov 28, 2024
Draft
Draft
bbakerman
bbakerman approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly this is such a large change I have to trust you in many ways - and the good news is - I do trust you

It has the tests needed and its a domain you are an expert in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbakerman bbakerman bbakerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnawf @bbakerman