Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fwdctl dump #348

Open
rkuris opened this issue Nov 11, 2023 · 5 comments
Open

Improve fwdctl dump #348

rkuris opened this issue Nov 11, 2023 · 5 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@rkuris
Copy link
Collaborator

rkuris commented Nov 11, 2023

Right now, the dump command only takes a database name. It would be easy to add options now:

  • output formats json and/or csv (these would need to be streaming for large databases)
  • specific starting key
  • specific stop key
  • maximum number of keys
  • if we stopped, have an option to render the next key for resuming

Some of these stream limits are already implemented for range proofs, so you can use the code there as a template of how to stop iterating.

(depends on #347)

@rkuris rkuris added the good first issue Good for newcomers label Nov 11, 2023
@rkuris rkuris moved this from Backlog 🗄️ to Ready ⏳ in Platform Engineering Group Nov 18, 2023
@rkuris rkuris added this to the v0.0.5 milestone Nov 18, 2023
@rkuris
Copy link
Collaborator Author

rkuris commented Nov 18, 2023

import from json (or any format) would also be amazing

@sergerad
Copy link
Contributor

@rkuris are there any unit or integration tests that cover the relevant flow here to help get my head around the stack? Or perhaps the examples/insert.rs might be relevant to look at? Thanks.

@zdf1230
Copy link

zdf1230 commented Dec 17, 2024

@rkuris Hi Ron, I am trying to work on this change and have a question regarding to "if we stopped, have an option to render the next key for resuming".

  1. Does the stopping here mean interrupt in the middle / crush or it reached the stopped key or max number of keys?
  2. Is storing a temporary file locally a good approach to resume? or do you have any ideas in mind?

Thanks!

@rkuris
Copy link
Collaborator Author

rkuris commented Dec 17, 2024 via email

@zdf1230
Copy link

zdf1230 commented Dec 17, 2024

Let's say you have keys A to Z and ask for a limit of 10 keys. In that

case, it would be nice if it told you that you can get the next set by

starting at K (the 11th key). I imagine the output could look like this:

A

B

...

J

Next key is K, resume with "--start-key=K"

On Mon, Dec 16, 2024, 9:28 PM zdf @.***> wrote:

@rkuris https://github.com/rkuris Hi Ron, I am trying to work on this

change and have a question regarding to "if we stopped, have an option to

render the next key for resuming".

  1. Does the stopping here mean interrupt in the middle / crush or it

reached the stopped key or max number of keys?

  1. Is storing a temporary file locally a good approach to resume? or

do you have any ideas in mind?

Thanks!

Reply to this email directly, view it on GitHub

#348 (comment),

or unsubscribe

https://github.com/notifications/unsubscribe-auth/AAYLR3FBOLLEWZQOLRSKT3D2F6Y7RAVCNFSM6AAAAABSGKBPZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBXGUZTQMRYGI

.

You are receiving this because you were mentioned.Message ID:

@.***>

Got it. Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Ready ⏳
Development

No branches or pull requests

5 participants