remove CrossChainApplications examples #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove CrossChainApplications examples
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
feuGeneA
force-pushed
the
feuGeneA/rm-examples
branch
3 times, most recently
from
cad72b9
to
f1e5e44
Compare
feuGeneA
force-pushed
the
feuGeneA/rm-examples
branch
from
f1e5e44
to
e6fed71
Compare
feuGeneA
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
geoff-vball and
bernard-avalabs
as code owners
geoff-vball
previously approved these changes
Jun 10, 2024
This should be an accurate view of the e2e contract code coverage (at least when comparing before/after), since we only ever interact with the contracts via the ABI bindings in the tests. |
Signed-off-by: F. Eugene Aumson <[email protected]>
geoff-vball
approved these changes
Jun 12, 2024
cam-schultz
approved these changes
Jun 12, 2024
bernard-avalabs
approved these changes
Jun 12, 2024
| @@ -17,10 +17,10 @@ import {ReentrancyGuard} from "@openzeppelin/[email protected]/security/Reentrancy | |||
| */ | |||
|
|
|||
| /** | |||
| * @dev ExampleCrossChainMessenger is an example contract that demonstrates how to send and receive | |||
| * @dev TestMessenger is test fixture contract that exercises sending and receiving | |||
There was a problem hiding this comment.
Suggested change
| * @dev TestMessenger is test fixture contract that exercises sending and receiving | |
| * @dev TestMessenger is a test fixture contract that exercises sending and receiving |
| @@ -17,10 +17,10 @@ import {ReentrancyGuard} from "@openzeppelin/[email protected]/security/Reentrancy | |||
| */ | |||
|
|
|||
| /** | |||
| * @dev ExampleCrossChainMessenger is an example contract that demonstrates how to send and receive | |||
| * @dev TestMessenger is test fixture contract that exercises sending and receiving | |||
| * messages cross chain. | |||
There was a problem hiding this comment.
Suggested change
| * messages cross chain. | |
| * messages across chains. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes #381
The actual migration of any of these examples, into the avalanche-starter-kit, as specified by ava-labs/avalanche-starter-kit#5, can happen independently of this removal.
How this was tested
I found that you can enable a go coverage report for Ginkgo test runs. Of course it doesn't provide any coverage for the contracts themselves, but I was able to focus the coverage report on just the contracts' ABI bindings. I found that the coverage report was identical before and after the removal of these tests. Therefore, I think removing these tests likely has no impact on test coverage.