Fix skip transcoding with minio/s3 file #5615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
force-pushed
the
minio_pass_through
branch
from
e6b24ff to
98b5fd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pass through encode model previously copied the s3 content into a local tempfile and passed that to active_encode to workaround the issue of mediainfo not being able to read s3 urls. That may have worked at one point but now the tempfiles get deleted/garbage collected after one read so mediainfo always returns an empty xml file leading to failed encodes. This PR resolves this by making changes to the PassThroughAdapter in active_encode and then relying on that instead of having a workaround locally.
samvera-labs/active_encode#132
This PR also resolves an issue with FileLocator::S3File that I discovered while debugging this issue locally. The
single_requestmode is not as efficient as a multi-part download but was the only way I could get it to work with minio.Related to #5594