Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mapping of browser keywords to expected browser-name #49

Open
dalmia opened this issue Mar 9, 2021 · 0 comments
Open

Use mapping of browser keywords to expected browser-name #49

dalmia opened this issue Mar 9, 2021 · 0 comments
Labels
cleanup Technical debt / beautification good first issue Good for newcomers priority : low Low priority item

Comments

@dalmia
Copy link
Member

dalmia commented Mar 9, 2021

Describe the bug
Currently, when extracting the browser name, we are hardcoding some outlier keywords to search for which we then map to expected browser names (look at the case of JioPages for the function get_user_agent_info under utils/request.py. Might be better to have a mapping between the expected keyword and the desired browser name.
@dalmia dalmia added good first issue Good for newcomers cleanup Technical debt / beautification labels Mar 9, 2021
@dalmia dalmia mentioned this issue Mar 9, 2021
Merged
@dalmia dalmia added the priority : low Low priority item label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Technical debt / beautification good first issue Good for newcomers priority : low Low priority item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dalmia