Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feedback on user interaction #4

Open
andrixb opened this issue Sep 8, 2017 · 2 comments
Open

add feedback on user interaction #4

andrixb opened this issue Sep 8, 2017 · 2 comments

Comments

@andrixb
Copy link

andrixb commented Sep 8, 2017

Hi there and very nice idea,

I believe it'd nice to give the user a visual feedback when it is able to click somewhere.
I made a small change adding a shadow effect when the mouse is over a card.
I've seen that you have something similar commented out in your code.
What was you issue?

Have you considered to add PostCSS in your build setup for autoprefixer at least?
Have you considered as well to add a CSS preprocessor (Sass, or why not a PostCSS plugin bundle that would replicate Sass-like features?)

I'll open a PR (mouseover branch) though:
#3

Thanks,
Andrea

@aviaryan
Copy link
Owner

aviaryan commented Sep 8, 2017

Hi there and very nice idea,

Thanks Andrea 😄

I believe it'd nice to give the user a visual feedback when it is able to click somewhere.
I made a small change adding a shadow effect when the mouse is over a card.
I've seen that you have something similar commented out in your code.
What was you issue?

I guess it was looking ok without that. But I don't remember for sure, I will try your patch and see how it feels. Thanks for the PR. ❤️

Have you considered to add PostCSS in your build setup for autoprefixer at least?
Have you considered as well to add a CSS preprocessor (Sass, or why not a PostCSS plugin bundle that would replicate Sass-like features?)

No, haven't thought about it yet. I am no front end expert and setting up Webpack and doing my first React project was a big deal for me, so didn't think that much. I think we can have PostCSS (for autoprefixer) now. Would you like to send a PR?

@andrixb
Copy link
Author

andrixb commented Sep 8, 2017

If the shadow doesn't work I believe we'd need to find a different visual hint: it took me at least a couple of secs to understand where I was interacting and what I could have clicked. The shadow in this way should - IMHO - remark upon the visual area.

I'm going to open a new branch for PostCSS.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants