Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Web Design Playground, Second Edition #215

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stjepanjurekovic
Copy link
Contributor

@stjepanjurekovic stjepanjurekovic commented Feb 23, 2023

Hi,

Stjepan here from Manning. I thought this title might be a good match for your list. Thank you for considering it.

Best,

What does this PR do?

Which issue is this PR related to?

If not related to any issue leave blank.

Does this PR follows our contribution guidelines?

Summary by CodeRabbit

  • Documentation
    • Enhanced clarity and structure of the README document.
    • Added a "Complementary Resources" section with links to external CSS resources.
    • Introduced a "Table of Contents" for easier navigation.
    • Expanded the "Books" section with new entries for additional learning materials.
    • Retained existing sections on CSS practices, guidelines, and resources for user reference.

Hi,

Stjepan here from Manning. I thought this title might be a good match for your list. Thank you for considering it.

Best,
Hi,

Stjepan here from Manning. I thought this title might be a good match for your list. Thank you for considering it.

Best,
README.md Outdated
Comment on lines 373 to 374
* [Web Design Playground, Second Edition](https://www.manning.com/books/web-design-playground-second-edition) – Written by web designer and master teacher Paul McFedries, this unique book shapes and sharpens your skills in the always-relevant technologies of the web.
* [CSS in Depth, Second Edition](https://www.manning.com/books/css-in-depth-second-edition) – Book about the CSS techniques used by the world’s most skilled web developers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stjepanjurekovic Please add in correct alphabetical order.

Copy link

coderabbitai bot commented Oct 14, 2024

Walkthrough

The changes in the pull request primarily involve updates to the README.md file, enhancing its structure and content. The introduction has been clarified to specify that the document serves as a curated list of CSS resources, excluding learning resources. A new "Complementary Resources" section has been added, and a "Table of Contents" has been generated for easier navigation. Existing sections on CSS-related topics have been retained without significant alterations, improving the document's clarity and usability.

Changes

File Change Summary
README.md Updated introduction for clarity, added "Complementary Resources" section, generated "Table of Contents", and retained existing sections without significant changes.

Poem

In the garden of code where the CSS grows,
A README blooms bright, with structure it shows.
Links to resources, a table to guide,
Hop through the sections, let knowledge abide!
With clarity shining, we dance in delight,
For every new change makes our coding take flight! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 308fe4f and 7e6edf2.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
README.md (1)

373-374: New book entries look good, but consider using dashes for consistency.

The new book entries "Web Design Playground, Second Edition" and "CSS in Depth, Second Edition" are valuable additions to the list. However, to maintain consistency with the rest of the document, consider using dashes (-) instead of asterisks (*) for these list items.

Here's the suggested change:

-* [Web Design Playground, Second Edition](https://www.manning.com/books/web-design-playground-second-edition) – Written by web designer and master teacher Paul McFedries, this unique book shapes and sharpens your skills in the always-relevant technologies of the web.
-* [CSS in Depth, Second Edition](https://www.manning.com/books/css-in-depth-second-edition) – Book about the CSS techniques used by the world's most skilled web developers.
+- [Web Design Playground, Second Edition](https://www.manning.com/books/web-design-playground-second-edition) – Written by web designer and master teacher Paul McFedries, this unique book shapes and sharpens your skills in the always-relevant technologies of the web.
+- [CSS in Depth, Second Edition](https://www.manning.com/books/css-in-depth-second-edition) – Book about the CSS techniques used by the world's most skilled web developers.
🧰 Tools
🪛 Markdownlint

373-373: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)


374-374: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between c5147e5 and 308fe4f.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
README.md

373-373: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)


374-374: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)

🔇 Additional comments (1)
README.md (1)

373-374: LGTM with minor formatting suggestion.

The new book entries are excellent additions to the "Books" section, providing valuable resources for CSS learners and professionals. The content is relevant and well-described. With the minor formatting adjustment to use dashes instead of asterisks for list items, this change will be perfect and consistent with the rest of the document.

🧰 Tools
🪛 Markdownlint

373-373: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)


374-374: Expected: dash; Actual: asterisk
Unordered list style

(MD004, ul-style)

Comment on lines +373 to +374
- [Web Design Playground, Second Edition](https://www.manning.com/books/web-design-playground-second-edition) – Written by web designer and master teacher Paul McFedries, this unique book shapes and sharpens your skills in the always-relevant technologies of the web.
- [CSS in Depth, Second Edition](https://www.manning.com/books/css-in-depth-second-edition) – Book about the CSS techniques used by the world’s most skilled web developers.
Copy link
Member

@Rishabh04-02 Rishabh04-02 Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stjepanjurekovic The newly added content is still placed at incorrect positions.

CSS in Depth, Second Edition should be placed before line L368
Web Design Playground, Second Edition is placed correctly in the end of the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants