-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Web Design Playground, Second Edition #215
base: master
Are you sure you want to change the base?
Added Web Design Playground, Second Edition #215
Conversation
Hi, Stjepan here from Manning. I thought this title might be a good match for your list. Thank you for considering it. Best,
Hi, Stjepan here from Manning. I thought this title might be a good match for your list. Thank you for considering it. Best,
Added CSS in Depth, Second Edition
README.md
Outdated
* [Web Design Playground, Second Edition](https://www.manning.com/books/web-design-playground-second-edition) – Written by web designer and master teacher Paul McFedries, this unique book shapes and sharpens your skills in the always-relevant technologies of the web. | ||
* [CSS in Depth, Second Edition](https://www.manning.com/books/css-in-depth-second-edition) – Book about the CSS techniques used by the world’s most skilled web developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stjepanjurekovic Please add in correct alphabetical order.
WalkthroughThe changes in the pull request primarily involve updates to the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
README.md (1)
373-374
: New book entries look good, but consider using dashes for consistency.The new book entries "Web Design Playground, Second Edition" and "CSS in Depth, Second Edition" are valuable additions to the list. However, to maintain consistency with the rest of the document, consider using dashes (-) instead of asterisks (*) for these list items.
Here's the suggested change:
-* [Web Design Playground, Second Edition](https://www.manning.com/books/web-design-playground-second-edition) – Written by web designer and master teacher Paul McFedries, this unique book shapes and sharpens your skills in the always-relevant technologies of the web. -* [CSS in Depth, Second Edition](https://www.manning.com/books/css-in-depth-second-edition) – Book about the CSS techniques used by the world's most skilled web developers. +- [Web Design Playground, Second Edition](https://www.manning.com/books/web-design-playground-second-edition) – Written by web designer and master teacher Paul McFedries, this unique book shapes and sharpens your skills in the always-relevant technologies of the web. +- [CSS in Depth, Second Edition](https://www.manning.com/books/css-in-depth-second-edition) – Book about the CSS techniques used by the world's most skilled web developers.🧰 Tools
🪛 Markdownlint
373-373: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
374-374: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- README.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
README.md
373-373: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
374-374: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
🔇 Additional comments (1)
README.md (1)
373-374
: LGTM with minor formatting suggestion.The new book entries are excellent additions to the "Books" section, providing valuable resources for CSS learners and professionals. The content is relevant and well-described. With the minor formatting adjustment to use dashes instead of asterisks for list items, this change will be perfect and consistent with the rest of the document.
🧰 Tools
🪛 Markdownlint
373-373: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
374-374: Expected: dash; Actual: asterisk
Unordered list style(MD004, ul-style)
- [Web Design Playground, Second Edition](https://www.manning.com/books/web-design-playground-second-edition) – Written by web designer and master teacher Paul McFedries, this unique book shapes and sharpens your skills in the always-relevant technologies of the web. | ||
- [CSS in Depth, Second Edition](https://www.manning.com/books/css-in-depth-second-edition) – Book about the CSS techniques used by the world’s most skilled web developers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stjepanjurekovic The newly added content is still placed at incorrect positions.
CSS in Depth, Second Edition should be placed before line L368
Web Design Playground, Second Edition is placed correctly in the end of the list.
Hi,
Stjepan here from Manning. I thought this title might be a good match for your list. Thank you for considering it.
Best,
What does this PR do?
Which issue is this PR related to?
Does this PR follows our contribution guidelines?
Summary by CodeRabbit